components/policy/core/browser/cloud/message_util.cc - Issue 2150603002: Added policy device id validation similar to the existing DM token validation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/policy/core/browser/cloud/message_util.cc

Issue 2150603002: Added policy device id validation similar to the existing DM token validation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added policy device id validation similar to the existing DM token validation. BUG: 360708 Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/policy/device_local_account_policy_store.cc ('k') | components/policy/core/common/cloud/cloud_policy_validator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/policy/core/browser/cloud/message_util.cc

diff --git a/components/policy/core/browser/cloud/message_util.cc b/components/policy/core/browser/cloud/message_util.cc

index 0b203df5a8e2afa80d20361a76f31741adcab572..80673e3889b1590d2471eb4056e6d43f3554a2ab 100644

--- a/components/policy/core/browser/cloud/message_util.cc

+++ b/components/policy/core/browser/cloud/message_util.cc

@@ -71,6 +71,8 @@ int GetIDSForValidationStatus(CloudPolicyValidatorBase::Status status) {

return IDS_POLICY_VALIDATION_BAD_TIMESTAMP;

case CloudPolicyValidatorBase::VALIDATION_WRONG_TOKEN:

return IDS_POLICY_VALIDATION_WRONG_TOKEN;

+ case CloudPolicyValidatorBase::VALIDATION_WRONG_DEVICE_ID:

+ return IDS_POLICY_VALIDATION_WRONG_DEVICE_ID;

case CloudPolicyValidatorBase::VALIDATION_BAD_USERNAME:

return IDS_POLICY_VALIDATION_BAD_USERNAME;

case CloudPolicyValidatorBase::VALIDATION_POLICY_PARSE_ERROR: