src/crankshaft/lithium.cc - Issue 2150523002: [turbofan] Do not use the self reference for turbofan functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/lithium.cc

Issue 2150523002: [turbofan] Do not use the self reference for turbofan functions. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Pass in the self reference instead of using an is_self_ref_available flag. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/crankshaft/lithium.cc

diff --git a/src/crankshaft/lithium.cc b/src/crankshaft/lithium.cc

index 6f226da2809fe93140159fd2ac26e01c26f2c250..8ba35138c7a5bac4cc8b099bfb1c877a06100e7f 100644

--- a/src/crankshaft/lithium.cc

+++ b/src/crankshaft/lithium.cc

@@ -457,8 +457,8 @@ Handle<Code> LChunk::Codegen() {

if (generator.GenerateCode()) {

generator.CheckEnvironmentUsage();

CodeGenerator::MakeCodePrologue(info(), "optimized");

- Handle<Code> code =

- CodeGenerator::MakeCodeEpilogue(&assembler, nullptr, info());

+ Handle<Code> code = CodeGenerator::MakeCodeEpilogue(

+ &assembler, nullptr, info(), assembler.CodeObject());

generator.FinishCode(code);

CommitDependencies(code);

generator.source_position_table_builder()->EndJitLogging(

« no previous file with comments | « src/compiler/code-generator.cc ('k') | src/full-codegen/full-codegen.cc » ('j') | no next file with comments »