Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215043007: Web Animations: Expose timeline currentTime in IDL (Closed)

Created:
6 years, 9 months ago by Eric Willigers
Modified:
6 years, 8 months ago
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, Inactive, darktears, arv+blink, Steve Block, dino_apple.com, watchdog-blink-watchlist_google.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Web Animations: Expose timeline currentTime in IDL AnimationTimeline has currentTime of type double - the time value for this timeline. Web Animations spec, section 5.1 The AnimationTimeline interface http://dev.w3.org/fxtf/web-animations/#the-animationtimeline-interface BUG=357432 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170513

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 6

Patch Set 3 : isNull not isNullTime #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -12 lines) Patch
A + LayoutTests/web-animations-api/timeline-time.html View 2 chunks +8 lines, -7 lines 0 comments Download
M Source/core/animation/DocumentTimeline.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/animation/DocumentTimeline.cpp View 1 2 1 chunk +13 lines, -3 lines 0 comments Download
M Source/core/animation/DocumentTimelineTest.cpp View 1 2 1 chunk +7 lines, -2 lines 0 comments Download
M Source/core/animation/Timeline.idl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
Eric Willigers
6 years, 9 months ago (2014-03-28 01:21:10 UTC) #1
Eric Willigers
6 years, 9 months ago (2014-03-28 03:08:26 UTC) #2
Eric Willigers
+alancutter
6 years, 8 months ago (2014-03-30 23:06:04 UTC) #3
shans
lgtm https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/DocumentTimeline.cpp File Source/core/animation/DocumentTimeline.cpp (right): https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/DocumentTimeline.cpp#newcode147 Source/core/animation/DocumentTimeline.cpp:147: double DocumentTimeline::currentTime(bool& isNullTime) Is the reference here necessary ...
6 years, 8 months ago (2014-03-31 09:39:11 UTC) #4
dstockwell
lgtm https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/AnimationPlayer.cpp File Source/core/animation/AnimationPlayer.cpp (right): https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/AnimationPlayer.cpp#newcode289 Source/core/animation/AnimationPlayer.cpp:289: m_timeline->currentTime(isNullTime); Doesn't the old way still work? Seems ...
6 years, 8 months ago (2014-03-31 23:33:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/215043007/20001
6 years, 8 months ago (2014-03-31 23:33:30 UTC) #6
dstockwell
The CQ bit was unchecked by dstockwell@chromium.org
6 years, 8 months ago (2014-03-31 23:33:35 UTC) #7
Eric Willigers
https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/AnimationPlayer.cpp File Source/core/animation/AnimationPlayer.cpp (right): https://codereview.chromium.org/215043007/diff/20001/Source/core/animation/AnimationPlayer.cpp#newcode289 Source/core/animation/AnimationPlayer.cpp:289: m_timeline->currentTime(isNullTime); On 2014/03/31 23:33:29, dstockwell wrote: > Doesn't the ...
6 years, 8 months ago (2014-04-01 01:15:45 UTC) #8
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 8 months ago (2014-04-01 01:15:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/215043007/40001
6 years, 8 months ago (2014-04-01 01:15:56 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 01:38:48 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 01:38:48 UTC) #12
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 8 months ago (2014-04-01 02:53:07 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/215043007/40001
6 years, 8 months ago (2014-04-01 02:53:21 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 03:20:09 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 03:20:10 UTC) #16
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 8 months ago (2014-04-01 03:21:33 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/215043007/40001
6 years, 8 months ago (2014-04-01 03:21:38 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-01 03:58:27 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-01 03:58:27 UTC) #20
Eric Willigers
The CQ bit was checked by ericwilligers@chromium.org
6 years, 8 months ago (2014-04-01 04:01:30 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericwilligers@chromium.org/215043007/40001
6 years, 8 months ago (2014-04-01 04:01:39 UTC) #22
commit-bot: I haz the power
6 years, 8 months ago (2014-04-01 04:40:25 UTC) #23
Message was sent while issue was closed. 
Change committed as 170513

Powered by Google App Engine
This is Rietveld 408576698