Web Animations: Expose timeline currentTime in IDL

Source/core/animation/DocumentTimeline.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 126 matching lines @@
 {
     m_timer.stop();
 }
 
 void DocumentTimeline::DocumentTimelineTiming::serviceOnNextFrame()
 {
     if (m_timeline->m_document && m_timeline->m_document->view())
         m_timeline->m_document->view()->scheduleAnimation();
 }
 
+double DocumentTimeline::currentTime(bool& isNullTime)

[shans, 2014/03/31 09:39:11]

Is the reference here necessary for the IDL to work? Maybe indicate this in a
comment?

[dstockwell, 2014/03/31 23:33:29]

just 'isNull'

[Eric Willigers, 2014/04/01 01:15:45]

Done.

[Eric Willigers, 2014/04/01 01:15:45]

This is needed because the IDL has currentTime as potentially null:
    readonly attribute double? currentTime;

The generated code gen/blink/bindings/V8Timeline.cpp
has
    DocumentTimeline* impl = ...
    bool isNull = false;
    double v8Value = impl->currentTime(isNull);

Without the ? in the IDL, the generated code would be

    DocumentTimeline* impl = ...
    ... impl->currentTime() ...


I have added the parameter name isNull to the header for clarity.

+{
+    if (!m_document) {
+        isNullTime = true;
+        return std::numeric_limits<double>::quiet_NaN();
+    }
+    double result = m_document->animationClock().currentTime() - m_zeroTime;
+    isNullTime = isNull(result);
+    return result;
+}
+
 double DocumentTimeline::currentTime()
 {
-    if (!m_document)
-        return std::numeric_limits<double>::quiet_NaN();
-    return m_document->animationClock().currentTime() - m_zeroTime;
+    bool isNullTime;
+    return currentTime(isNullTime);
 }
 
 double DocumentTimeline::effectiveTime()
 {
     double time = currentTime();
     return std::isnan(time) ? 0 : time;
 }
 
 void DocumentTimeline::pauseAnimationsForTesting(double pauseTime)
 {
@@ skipping 25 matching lines @@
             count += (timedItem && (timedItem->isCurrent() || timedItem->isInEffect()));
     }
     return count;
 }
 
 void DocumentTimeline::detachFromDocument() {
     m_document = 0;
 }
 
 } // namespace