Serialize this-types in NativeBehavior separately.

Serialize this-types in NativeBehavior separately.

BUG=
R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/3305201211dc55f21ae8ad052fdd2a9ad7d06d31

[Johnni Winther, 2016-07-15 13:20:29]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Harry Terkelsen, 2016-07-15 16:03:10]

lgtm

what was the problem that prompted this cl? does the indexed_db import cause
some unusual behavior?

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_serialization.dart (right):

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:159: //
TODO(johnniwinther): Remove this when annotation are no longer resolved
nit: long line

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:176: return
types.where((type) {
maybe move this filter function to it's own local method so you can do
types.where(isThisType) above and types.where((x) => !isThisType(x)) here

[Johnni Winther, 2016-07-18 08:08:22]

On 2016/07/15 16:03:10, Harry Terkelsen wrote:
> lgtm
> 
> what was the problem that prompted this cl? does the indexed_db import cause
> some unusual behavior?
> 

I ran co19 which had a test importing dart:indexed_db. The problem is that this
has a @Creates('JSExtendableArray') annotation which currently add
JSExtendableArray<E> (its thisType) to the typesInstantiated property. Since
JSExtendableArray is serialized with dart:core, and thus in another
serialization unit than dart:indexed_db, we try to serialize 'E' which we don't
(and won't) support.

[Johnni Winther, 2016-07-18 08:42:35]

Description was changed from

==========
Serialize this-types in NativeBehavior separately.

BUG=
==========

to

==========
Serialize this-types in NativeBehavior separately.

BUG=
R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/3305201211dc55f21ae8ad052fdd2a9ad7d06d31
==========

[Johnni Winther, 2016-07-18 08:42:37]

Committed patchset #2 (id:20001) manually as
3305201211dc55f21ae8ad052fdd2a9ad7d06d31 (presubmit successful).

[Johnni Winther, 2016-07-18 10:44:17]

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend_serialization.dart (right):

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:159: //
TODO(johnniwinther): Remove this when annotation are no longer resolved
On 2016/07/15 16:03:10, Harry Terkelsen wrote:
> nit: long line

Done.

https://codereview.chromium.org/2150333002/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:176: return
types.where((type) {
On 2016/07/15 16:03:10, Harry Terkelsen wrote:
> maybe move this filter function to it's own local method so you can do
> types.where(isThisType) above and types.where((x) => !isThisType(x)) here

Done.