Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Unified Diff: tests/compiler/dart2js/serialization/helper.dart

Issue 2150333002: Serialize this-types in NativeBehavior separately. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Updated cf. comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/serialization/helper.dart
diff --git a/tests/compiler/dart2js/serialization/helper.dart b/tests/compiler/dart2js/serialization/helper.dart
index b6d77e7191ce09e6699a9235840fe6ebb8a70776..7d43fa1364ae081db33fa1dca7770899ebb66eda 100644
--- a/tests/compiler/dart2js/serialization/helper.dart
+++ b/tests/compiler/dart2js/serialization/helper.dart
@@ -169,7 +169,10 @@ class SerializedData {
final Uri uri;
final String data;
- SerializedData(this.uri, this.data);
+ SerializedData(this.uri, this.data) {
+ assert(uri != null);
+ assert(data != null);
+ }
Map<String, String> toMemorySourceFiles([Map<String, String> input]) {
Map<String, String> sourceFiles = <String, String>{};
@@ -200,13 +203,6 @@ class SerializedData {
}
}
-String extractSerializedData(
- Compiler compiler, Iterable<LibraryElement> libraries) {
- BufferedEventSink sink = new BufferedEventSink();
- compiler.serialization.serializeToSink(sink, libraries);
- return sink.text;
-}
-
Future<List<SerializedData>> preserializeData(
SerializedData serializedData, Test test) async {
if (test == null ||
@@ -223,19 +219,20 @@ Future<List<SerializedData>> preserializeData(
if (test.unserializedSourceFiles != null) {
sourceFiles.addAll(test.unserializedSourceFiles);
}
+ OutputCollector outputCollector = new OutputCollector();
Compiler compiler = compilerFor(
memorySourceFiles: sourceFiles,
resolutionInputs: serializedData.toUris(),
- options: [Flags.analyzeOnly, Flags.analyzeMain]);
+ options: [Flags.resolveOnly],
+ outputProvider: outputCollector);
compiler.librariesToAnalyzeWhenRun = uriList;
- compiler.serialization.supportSerialization = true;
await compiler.run(null);
List<LibraryElement> libraries = <LibraryElement>[];
for (Uri uri in uriList) {
libraries.add(compiler.libraryLoader.lookupLibrary(uri));
}
- SerializedData additionalSerializedData =
- new SerializedData(Uri.parse('memory:additional.data'),
- extractSerializedData(compiler, libraries));
+ SerializedData additionalSerializedData = new SerializedData(
+ Uri.parse('memory:additional.data'),
+ outputCollector.getOutput('', 'data'));
return <SerializedData>[serializedData, additionalSerializedData];
}
« no previous file with comments | « tests/compiler/dart2js/memory_source_file_helper.dart ('k') | tests/compiler/dart2js/serialization/test_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698