Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 215033003: Remove WebLayer::maxScrollPosition(). (Closed)

Created:
6 years, 9 months ago by wjmaclean
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium, bokan
Visibility:
Public.

Description

Remove WebLayer::maxScrollPosition(). This code is only used in a test, and cc-side support is going away, so remove it in Blink. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170480

Patch Set 1 #

Patch Set 2 : Remove WebLayer::maxScrollPosition(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M Source/web/tests/ScrollingCoordinatorChromiumTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M public/platform/WebLayer.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
wjmaclean
This code is unused in Blink, and relies on machinery that is going away in ...
6 years, 9 months ago (2014-03-27 20:13:44 UTC) #1
aelias_OOO_until_Jul13
lgtm
6 years, 9 months ago (2014-03-27 21:03:57 UTC) #2
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 9 months ago (2014-03-27 21:10:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/215033003/20001
6 years, 9 months ago (2014-03-27 21:10:27 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 21:35:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-27 21:35:35 UTC) #6
wjmaclean
The CQ bit was checked by wjmaclean@chromium.org
6 years, 9 months ago (2014-03-28 12:54:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/215033003/20001
6 years, 9 months ago (2014-03-28 12:55:04 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-28 13:02:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 9 months ago (2014-03-28 13:02:32 UTC) #10
abarth-chromium
lgtm
6 years, 8 months ago (2014-03-31 20:02:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wjmaclean@chromium.org/215033003/20001
6 years, 8 months ago (2014-03-31 20:02:22 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-03-31 20:13:31 UTC) #13
Message was sent while issue was closed. 
Change committed as 170480

Powered by Google App Engine
This is Rietveld 408576698