Issue 212603017: Remove scroll distribution code from Layer/LayerTreeHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 212603017: Remove scroll distribution code from Layer/LayerTreeHost. (Closed)

Created:
6 years, 9 months ago by wjmaclean

Modified:
6 years, 9 months ago

Reviewers:
aelias_OOO_until_Jul13

CC:
chromium-reviews, cc-bugs_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove scroll distribution code from Layer/LayerTreeHost. Modifications to allow Blink to control both inner and outer pinch viewports means we no longer need this code or the related tests.

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -211 lines)			Patch
M	cc/cc_tests.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/layers/layer.cc	View	2 chunks	+0 lines, -39 lines	0 comments	Download
M	cc/trees/layer_tree_host.cc	View	1 chunk	+0 lines, -44 lines	0 comments	Download
D	cc/trees/layer_tree_host_unittest_pinch_zoom.cc	View	1 chunk	+0 lines, -122 lines	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/renderer/compositor_bindings/web_layer_impl.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

wjmaclean

Remove scroll distribution code from CC to make way for Blink control of both inner/outer ...

6 years, 9 months ago (2014-03-27 20:14:51 UTC) #1

aelias_OOO_until_Jul13

Looks like mostly the same patch as https://codereview.chromium.org/210543002/ :)

6 years, 9 months ago (2014-03-28 01:00:08 UTC) #2

wjmaclean

On 2014/03/28 01:00:08, aelias wrote: > Looks like mostly the same patch as https://codereview.chromium.org/210543002/ > ...

6 years, 9 months ago (2014-03-28 12:48:22 UTC) #3

bokan

6 years, 9 months ago (2014-03-28 12:54:18 UTC) #4

Message was sent while issue was closed.

On 2014/03/28 12:48:22, wjmaclean wrote:
> On 2014/03/28 01:00:08, aelias wrote:
> > Looks like mostly the same patch as
https://codereview.chromium.org/210543002/
> > :)
> 
> Ogh, did not know about this other patch since I was not CC'd on it ... lack
of
> communication :-(

Sorry about that! I forgot to add the CC...

Expand Messages | Collapse Messages