Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2150273002:
Disable smoke test for v8.browsing benchmark. (Closed)
DescriptionDisable smoke test for v8.browsing benchmark.
BUG=628368
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq
Committed: https://crrev.com/defbb39e453be7d10061e094a718d85598291cda
Cr-Commit-Position: refs/heads/master@{#405758}
Patch Set 1 #Patch Set 2 : use correct black list #Messages
Total messages: 16 (6 generated)
Description was changed from ========== Disable smoke test for v8.browsing benchmark. BUG=628368 ========== to ========== Disable smoke test for v8.browsing benchmark. BUG=628368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
ulan@chromium.org changed reviewers: + nednguyen@google.com
ptal
Description was changed from ========== Disable smoke test for v8.browsing benchmark. BUG=628368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Disable smoke test for v8.browsing benchmark. BUG=628368 ==========
On 2016/07/15 10:26:08, ulan wrote: > ptal Oh, this should be done in benchmarks/benchmark_smoke_unittest.py instead. You benchmark are not run on system_health_smoke_test because it's not a system health benchmark.
Description was changed from ========== Disable smoke test for v8.browsing benchmark. BUG=628368 ========== to ========== Disable smoke test for v8.browsing benchmark. BUG=628368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ==========
On 2016/07/15 10:30:12, nednguyen wrote: > On 2016/07/15 10:26:08, ulan wrote: > > ptal > > Oh, this should be done in benchmarks/benchmark_smoke_unittest.py instead. You > benchmark are not run on system_health_smoke_test because it's not a system > health benchmark. Thank you! PTAL. We can only disable on module level? A bit unfortunate that desktop benchmark also gets disabled.
On 2016/07/15 10:46:16, ulan wrote: > On 2016/07/15 10:30:12, nednguyen wrote: > > On 2016/07/15 10:26:08, ulan wrote: > > > ptal > > > > Oh, this should be done in benchmarks/benchmark_smoke_unittest.py instead. You > > benchmark are not run on system_health_smoke_test because it's not a system > > health benchmark. > > Thank you! PTAL. We can only disable on module level? A bit unfortunate that > desktop benchmark also gets disabled. Currently we don't run all benchmarks on all module because that blows up the cycle time of Android bot. So you currently have desktop benchmark smoke tested anyway. See: https://codereview.chromium.org/2081403003/. I will probably update this CL so at least it run all benchmarks on desktop platforms.
lgtm
On 2016/07/15 11:47:27, nednguyen wrote: > On 2016/07/15 10:46:16, ulan wrote: > > On 2016/07/15 10:30:12, nednguyen wrote: > > > On 2016/07/15 10:26:08, ulan wrote: > > > > ptal > > > > > > Oh, this should be done in benchmarks/benchmark_smoke_unittest.py instead. > You > > > benchmark are not run on system_health_smoke_test because it's not a system > > > health benchmark. > > > > Thank you! PTAL. We can only disable on module level? A bit unfortunate that > > desktop benchmark also gets disabled. > > Currently we don't run all benchmarks on all module because that blows up the > cycle time of Android bot. So you currently have desktop benchmark smoke tested > anyway. > > See: https://codereview.chromium.org/2081403003/. I will probably update this CL > so at least it run all benchmarks on desktop platforms. Awesome, thank you!
The CQ bit was checked by ulan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Disable smoke test for v8.browsing benchmark. BUG=628368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== Disable smoke test for v8.browsing benchmark. BUG=628368 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq Committed: https://crrev.com/defbb39e453be7d10061e094a718d85598291cda Cr-Commit-Position: refs/heads/master@{#405758} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/defbb39e453be7d10061e094a718d85598291cda Cr-Commit-Position: refs/heads/master@{#405758} |
