Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: tools/perf/benchmarks/benchmark_smoke_unittest.py

Issue 2150273002: Disable smoke test for v8.browsing benchmark. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use correct black list Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 """Run the first page of one benchmark for every module. 5 """Run the first page of one benchmark for every module.
6 6
7 Only benchmarks that have a composable measurement are included. 7 Only benchmarks that have a composable measurement are included.
8 Ideally this test would be comprehensive, however, running one page 8 Ideally this test would be comprehensive, however, running one page
9 of every benchmark would run impractically long. 9 of every benchmark would run impractically long.
10 """ 10 """
(...skipping 12 matching lines...) Expand all
23 from benchmarks import indexeddb_perf 23 from benchmarks import indexeddb_perf
24 from benchmarks import jetstream 24 from benchmarks import jetstream
25 from benchmarks import kraken 25 from benchmarks import kraken
26 from benchmarks import memory 26 from benchmarks import memory
27 from benchmarks import octane 27 from benchmarks import octane
28 from benchmarks import rasterize_and_record_micro 28 from benchmarks import rasterize_and_record_micro
29 from benchmarks import repaint 29 from benchmarks import repaint
30 from benchmarks import spaceport 30 from benchmarks import spaceport
31 from benchmarks import speedometer 31 from benchmarks import speedometer
32 from benchmarks import text_selection 32 from benchmarks import text_selection
33 from benchmarks import v8_browsing
33 34
34 35
35 def SmokeTestGenerator(benchmark): 36 def SmokeTestGenerator(benchmark):
36 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST. 37 # NOTE TO SHERIFFS: DO NOT DISABLE THIS TEST.
37 # 38 #
38 # This smoke test dynamically tests all benchmarks. So disabling it for one 39 # This smoke test dynamically tests all benchmarks. So disabling it for one
39 # failing or flaky benchmark would disable a much wider swath of coverage 40 # failing or flaky benchmark would disable a much wider swath of coverage
40 # than is usally intended. Instead, if a particular benchmark is failing, 41 # than is usally intended. Instead, if a particular benchmark is failing,
41 # disable it in tools/perf/benchmarks/*. 42 # disable it in tools/perf/benchmarks/*.
42 @benchmark_module.Disabled('chromeos') # crbug.com/351114 43 @benchmark_module.Disabled('chromeos') # crbug.com/351114
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 indexeddb_perf, # Always fails on Win7 & Android Tests builder. 86 indexeddb_perf, # Always fails on Win7 & Android Tests builder.
86 octane, # Often fails & take long time to timeout on cq bot. 87 octane, # Often fails & take long time to timeout on cq bot.
87 rasterize_and_record_micro, # Always fails on cq bot. 88 rasterize_and_record_micro, # Always fails on cq bot.
88 repaint, # Often fails & takes long time to timeout on cq bot. 89 repaint, # Often fails & takes long time to timeout on cq bot.
89 spaceport, # Takes 451 seconds. 90 spaceport, # Takes 451 seconds.
90 speedometer, # Takes 101 seconds. 91 speedometer, # Takes 101 seconds.
91 jetstream, # Take 206 seconds. 92 jetstream, # Take 206 seconds.
92 text_selection, # Always fails on cq bot. 93 text_selection, # Always fails on cq bot.
93 memory, # Flaky on bots, crbug.com/513767. 94 memory, # Flaky on bots, crbug.com/513767.
94 kraken, # Flaky on Android, crbug.com/626174. 95 kraken, # Flaky on Android, crbug.com/626174.
96 v8_browsing # Flaky on Android, crbug.com/628368.
95 } 97 }
96 98
97 99
98 def load_tests(loader, standard_tests, pattern): 100 def load_tests(loader, standard_tests, pattern):
99 del loader, standard_tests, pattern # unused 101 del loader, standard_tests, pattern # unused
100 suite = progress_reporter.TestSuite() 102 suite = progress_reporter.TestSuite()
101 103
102 benchmarks_dir = os.path.dirname(__file__) 104 benchmarks_dir = os.path.dirname(__file__)
103 top_level_dir = os.path.dirname(benchmarks_dir) 105 top_level_dir = os.path.dirname(benchmarks_dir)
104 106
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 merged_attributes = getattr(method, attribute, set()).union( 139 merged_attributes = getattr(method, attribute, set()).union(
138 getattr(benchmark, attribute, set())) 140 getattr(benchmark, attribute, set()))
139 if merged_attributes: 141 if merged_attributes:
140 setattr(method, attribute, merged_attributes) 142 setattr(method, attribute, merged_attributes)
141 143
142 setattr(BenchmarkSmokeTest, benchmark.Name(), method) 144 setattr(BenchmarkSmokeTest, benchmark.Name(), method)
143 145
144 suite.addTest(BenchmarkSmokeTest(benchmark.Name())) 146 suite.addTest(BenchmarkSmokeTest(benchmark.Name()))
145 147
146 return suite 148 return suite
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698