chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java - Issue 2150213002: [TTS] Handle showing of a Context Menu more gracefully.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

Issue 2150213002: [TTS] Handle showing of a Context Menu more gracefully. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just a comment. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchSelectionController.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

index 7c85d0314f810fbc540b5454cc82fd211f8f4a4c..ecc352655c0745a1920854173e73d8c877cf2431 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTabHelper.java

@@ -5,6 +5,7 @@

package org.chromium.chrome.browser.contextualsearch;

import android.app.Activity;

+import android.view.ContextMenu;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.chrome.browser.ChromeActivity;

@@ -123,6 +124,14 @@ public class ContextualSearchTabHelper extends EmptyTabObserver {

updateHooksForNewContentViewCore(tab);

}

+ @Override

+ public void onContextMenuShown(Tab tab, ContextMenu menu) {

+ ContextualSearchManager manager = getContextualSearchManager();

+ if (manager != null) {

+ manager.onContextMenuShown();

+ }

/**

* Should be called whenever the Tab's ContentViewCore changes. Removes hooks from the

* existing ContentViewCore, if necessary and then adds hooks for the new ContentViewCore.