Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2150103002: [Offline Pages] Allows offline redirection to offline pages with Aync Loading namespace. (Closed)

Created:
4 years, 5 months ago by dougarnett
Modified:
4 years, 5 months ago
Reviewers:
romax, fgorski
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Allows offline redirection to offline pages with Aync Loading namespace. BUG=628029 Committed: https://crrev.com/847efb8039e8fd04c71c3d1426581b6f4a4f0f43 Cr-Commit-Position: refs/heads/master@{#405760}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -0 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
dougarnett
4 years, 5 months ago (2016-07-14 21:10:37 UTC) #4
fgorski
lgtm
4 years, 5 months ago (2016-07-14 22:21:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2150103002/1
4 years, 5 months ago (2016-07-15 15:41:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 15:46:35 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 15:46:42 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 15:48:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/847efb8039e8fd04c71c3d1426581b6f4a4f0f43
Cr-Commit-Position: refs/heads/master@{#405760}

Powered by Google App Engine
This is Rietveld 408576698