chrome/browser/android/offline_pages/offline_page_tab_helper.cc - Issue 2150103002: [Offline Pages] Allows offline redirection to offline pages with Aync Loading namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

Issue 2150103002: [Offline Pages] Allows offline redirection to offline pages with Aync Loading namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/offline_pages/offline_page_tab_helper.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc

index b307ad890755b9eca75a64313db1ccd2b9b7aca2..b56b7d1c9b1900edebc3161908adc05a9fe83519 100644

--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.cc

+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.cc

@@ -212,6 +212,7 @@ void OfflinePageTabHelper::SelectBestPageForRedirectToOffline(

const OfflinePageItem* selected_page = nullptr;

for (const auto& offline_page : pages) {

if ((offline_page.client_id.name_space == kBookmarkNamespace) ||

+ (offline_page.client_id.name_space == kAsyncNamespace) ||

(offline_page.client_id.name_space == kLastNNamespace &&

offline_page.client_id.id == tab_id)) {

if (!selected_page ||

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc » ('j') | no next file with comments »