Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes

Committed: https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae
Cr-Commit-Position: refs/heads/master@{#405594}

[James Cook, 2016-07-14 18:46:03]

Description was changed from

==========
Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes
==========

to

==========
Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes
==========

[James Cook, 2016-07-14 18:58:11]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:59:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-14 18:59:16]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-14 18:59:18]

msw, please take a look. This CL + some chromeos singleton initialization + fix
for strings/resources should let us display the status area widget. So...
close...

https://codereview.chromium.org/2150023002/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2150023002/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:141:
SetMediaDelegate(base::WrapUnique(delegate()->CreateMediaDelegate()));
This is why I renamed the constructor parameter to shell_delegate. After the
std::move() shell_delegate is null, so I have to call delegate() here.

[commit-bot: I haz the power, 2016-07-14 19:05:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:05:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[James Cook, 2016-07-14 19:15:33]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 19:15:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-14 19:50:05]

lgtm with a nit and a q.

https://codereview.chromium.org/2150023002/diff/20001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2150023002/diff/20001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:141:
SetMediaDelegate(base::WrapUnique(delegate()->CreateMediaDelegate()));
On 2016/07/14 18:59:18, James Cook wrote:
> This is why I renamed the constructor parameter to shell_delegate. After the
> std::move() shell_delegate is null, so I have to call delegate() here.

Acknowledged.

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:141:
SetMediaDelegate(base::WrapUnique(delegate()->CreateMediaDelegate()));
q: Would it make sense to move the corresponding ash::Shell init to WmShellAura?
(and similar for accessibility, etc? it'd be nice to reduce ash::Shell's duties)

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.h (right):

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.h:21: explicit
ShellDelegateMus(std::unique_ptr<app_list::AppListPresenter>);
optional nit: give this parameter a name here, |app_list_presenter|.

[msw, 2016-07-14 19:50:34]

On 2016/07/14 18:59:18, James Cook wrote:
> This CL + some chromeos singleton initialization + fix
> for strings/resources should let us display the status area widget. So...
> close...

Exciting!!!

[commit-bot: I haz the power, 2016-07-14 20:27:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 20:27:26]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[James Cook, 2016-07-14 20:54:44]

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:141:
SetMediaDelegate(base::WrapUnique(delegate()->CreateMediaDelegate()));
On 2016/07/14 19:50:05, msw wrote:
> q: Would it make sense to move the corresponding ash::Shell init to
WmShellAura?
> (and similar for accessibility, etc? it'd be nice to reduce ash::Shell's
duties)

I think the right thing to do here is to have the WmShell constructor call
delegate->CreateMediaDelegate() and eliminate the SetMediaDelegate() method. I
didn't do that here because it substantially changes the ordering of
initialization of some media code in Chrome.  I'll give it a try in a follow-on
CL so it'll be easily blame-able if I break something.

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/shell_delegate_...
File ash/mus/shell_delegate_mus.h (right):

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/shell_delegate_...
ash/mus/shell_delegate_mus.h:21: explicit
ShellDelegateMus(std::unique_ptr<app_list::AppListPresenter>);
On 2016/07/14 19:50:05, msw wrote:
> optional nit: give this parameter a name here, |app_list_presenter|.

Whoops! Done.

[James Cook, 2016-07-14 20:54:52]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-14 20:54:52]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2150023002/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2016-07-14 20:55:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[msw, 2016-07-14 20:58:04]

still lgtm

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
File ash/mus/bridge/wm_shell_mus.cc (right):

https://codereview.chromium.org/2150023002/diff/40001/ash/mus/bridge/wm_shell...
ash/mus/bridge/wm_shell_mus.cc:141:
SetMediaDelegate(base::WrapUnique(delegate()->CreateMediaDelegate()));
On 2016/07/14 20:54:44, James Cook wrote:
> On 2016/07/14 19:50:05, msw wrote:
> > q: Would it make sense to move the corresponding ash::Shell init to
> WmShellAura?
> > (and similar for accessibility, etc? it'd be nice to reduce ash::Shell's
> duties)
> 
> I think the right thing to do here is to have the WmShell constructor call
> delegate->CreateMediaDelegate() and eliminate the SetMediaDelegate() method. I
> didn't do that here because it substantially changes the ordering of
> initialization of some media code in Chrome.  I'll give it a try in a
follow-on
> CL so it'll be easily blame-able if I break something.

Acknowledged.

[commit-bot: I haz the power, 2016-07-14 22:09:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-14 22:12:41]

Description was changed from

==========
Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes
==========

to

==========
Add ShellDelegate, MediaDelegate and KeyboardUI stubs to mus ash

These will be necessary to get the StatusAreaWidget to display in mojo:ash.

* Fork ash::sysui::ShellDelegateMus into //ash/mus
* Convert WmShell constructors to take ShellDelegate via unique_ptr
* Use ash::KeyboardUI for now, rather than KeyboardUIMus
* Move GPUSupport and PointerWatcherDelegate to //ash/common
* Fix some IWYU

No functional changes for regular non-mash chrome.

BUG=619636
TEST=ash_unittests, run chrome --mash manually and no crashes

Committed: https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae
Cr-Commit-Position: refs/heads/master@{#405594}
==========

[commit-bot: I haz the power, 2016-07-14 22:12:42]

Patchset 4 (id:??) landed as
https://crrev.com/333757306609d5ae15085538c025b2d38782a2ae
Cr-Commit-Position: refs/heads/master@{#405594}