Create ash media delegate earlier during ash shell initialization

Create ash media delegate earlier during ash shell initialization

This allows it to be created directly by WmShell, similar to how ash::Shell
used to create it, and eliminates the WmShell::SetMediaDelegate() method.

BUG=none
TEST=ash_unittests, unit_tests

Committed: https://crrev.com/3daef4173c0917c938ef34c9ac6d5a38cb568350
Cr-Commit-Position: refs/heads/master@{#405637}

[James Cook, 2016-07-14 21:22:48]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 21:23:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-14 21:56:49]

The CQ bit was checked by jamescook@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 21:57:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-14 22:03:23]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-07-14 22:03:24]

msw, please take a look

https://codereview.chromium.org/2144363003/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2144363003/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:47: // instead of the WmShell constructor.
This is not strictly needed for the media delegate. It will be needed for the
accessibility delegate (which I'm above to move) and others. It seemed better to
me to call all the ShellDelegate::CreateFoo() methods in one place. This also
more closely resembles the ash::Shell init order.

[msw, 2016-07-14 22:49:34]

lgtm

https://codereview.chromium.org/2144363003/diff/20001/ash/common/wm_shell.cc
File ash/common/wm_shell.cc (right):

https://codereview.chromium.org/2144363003/diff/20001/ash/common/wm_shell.cc#...
ash/common/wm_shell.cc:47: // instead of the WmShell constructor.
On 2016/07/14 22:03:24, James Cook wrote:
> This is not strictly needed for the media delegate. It will be needed for the
> accessibility delegate (which I'm above to move) and others. It seemed better
to
> me to call all the ShellDelegate::CreateFoo() methods in one place. This also
> more closely resembles the ash::Shell init order.
> 
> 

Acknowledged.

https://codereview.chromium.org/2144363003/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2144363003/diff/20001/ash/shell.cc#newcode811
ash/shell.cc:811: in_mus_ = init_params.in_mus;
aside: hopefully WmShell Init delegates won't rely on this, etc. We may
encounter ordering dependency issues like that, as you noted in the prior CL,
hopefully they'll make themselves apparent.

[James Cook, 2016-07-14 22:52:52]

https://codereview.chromium.org/2144363003/diff/20001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/2144363003/diff/20001/ash/shell.cc#newcode811
ash/shell.cc:811: in_mus_ = init_params.in_mus;
On 2016/07/14 22:49:34, msw wrote:
> aside: hopefully WmShell Init delegates won't rely on this, etc. We may
> encounter ordering dependency issues like that, as you noted in the prior CL,
> hopefully they'll make themselves apparent.

Yeah, all this startup ordering stuff is hard. I think in the medium-term
ash::Shell::in_mus_ will move into WmShell, which will help a little.

[commit-bot: I haz the power, 2016-07-14 23:03:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:03:48]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-07-14 23:13:32]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-07-14 23:13:33]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/2144363003/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-14 23:14:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:53:43]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-14 23:55:35]

Description was changed from

==========
Create ash media delegate earlier during ash shell initialization

This allows it to be created directly by WmShell, similar to how ash::Shell
used to create it, and eliminates the WmShell::SetMediaDelegate() method.

BUG=none
TEST=ash_unittests, unit_tests
==========

to

==========
Create ash media delegate earlier during ash shell initialization

This allows it to be created directly by WmShell, similar to how ash::Shell
used to create it, and eliminates the WmShell::SetMediaDelegate() method.

BUG=none
TEST=ash_unittests, unit_tests

Committed: https://crrev.com/3daef4173c0917c938ef34c9ac6d5a38cb568350
Cr-Commit-Position: refs/heads/master@{#405637}
==========

[commit-bot: I haz the power, 2016-07-14 23:55:36]

Patchset 3 (id:??) landed as
https://crrev.com/3daef4173c0917c938ef34c9ac6d5a38cb568350
Cr-Commit-Position: refs/heads/master@{#405637}