Chromium Code Reviews Chromium Code Reviews
Issue 2150003005:
Add grid/flex layout support for <fieldset> (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..c6077aacfc28d2178f1cc2d8b2a2e35f8be3d5af |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html |
| @@ -0,0 +1,47 @@ |
| +<!DOCTYPE html> |
| +<html> |
| +<head> |
| +<title>Test Case with FIELDSET as grid container</title> |
|
Manuel Rego
2016/07/20 06:00:23
Same comments about tags and title like in the pre
Gleb Lanbin
2016/07/21 18:25:31
Done.
|
| +<style> |
| +.grid > div { |
| + border-style: solid; |
| + border-width: 1px; |
| +} |
| +.grid { |
| + display: grid; |
| + height: 200px; |
| + width: 200px; |
| +} |
| +.nw{ |
|
Manuel Rego
2016/07/20 06:00:23
Please use more descriptive names for the CSS clas
Gleb Lanbin
2016/07/21 18:25:31
Done.
|
| + grid-column:1; |
| + grid-row:1; |
| + border-color: blue; |
| +} |
| +.ne{ |
| + grid-column:2; |
| + grid-row:1; |
| + border-color: red; |
| +} |
| +.sw{ |
| + grid-column:1; |
| + grid-row:2; |
| + border-color: green; |
| +} |
| +.se{ |
| + grid-column:2; |
| + grid-row:2; |
| + border-color: orange; |
| +} |
| +</style> |
| +</head> |
| + |
| +<body> |
|
Manuel Rego
2016/07/20 06:00:23
In this case we clearly miss a description of the
Gleb Lanbin
2016/07/21 18:25:31
Done.
|
| +<fieldset class="grid"> |
| + <legend>Fieldset with display: grid</legend> |
| + <div class="nw">NW</div> |
| + <div class="ne">NE</div> |
| + <div class="sw">SW</div> |
| + <div class="se">SE</div> |
| +</fieldset> |
| +</body> |
| +</html> |
