third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html - Issue 2150003005: Add grid/flex layout support for <fieldset>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-grid.html

Issue 2150003005: Add grid/flex layout support for <fieldset> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: updated TestExpectations and fixed legend-after-margin-vertical-writing-mode.html Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html ('K') | « third_party/WebKit/LayoutTests/fast/forms/fieldset/fieldset-display-flex.html ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutFieldset.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <title>Test Case with FIELDSET as grid container</title>
	Manuel Rego 2016/07/20 06:00:23 Same comments about tags and title like in the pre Same comments about tags and title like in the previous test. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > Same comments about tags and title like in the previous test. Done.
	5 <style>

	6 .grid > div {

	7 border-style: solid;

	8 border-width: 1px;

	9 }

	10 .grid {

	11 display: grid;

	12 height: 200px;

	13 width: 200px;

	14 }

	15 .nw{
	Manuel Rego 2016/07/20 06:00:23 Please use more descriptive names for the CSS clas Please use more descriptive names for the CSS classes. Something like firstRowFirstColumn is much clearer. For Grid Layout you could reuse some CSS classes from: fast/css-grid-layout-resources/grid.css (anyway you can define your own ones, not a big deal). Nit: Missing space between class name and bracket. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > Please use more descriptive names for the CSS classes. > Something like firstRowFirstColumn is much clearer. > > For Grid Layout you could reuse some CSS classes from: > fast/css-grid-layout-resources/grid.css > (anyway you can define your own ones, not a big deal). > > Nit: Missing space between class name and bracket. Done.
	16 grid-column:1;

	17 grid-row:1;

	18 border-color: blue;

	19 }

	20 .ne{

	21 grid-column:2;

	22 grid-row:1;

	23 border-color: red;

	24 }

	25 .sw{

	26 grid-column:1;

	27 grid-row:2;

	28 border-color: green;

	29 }

	30 .se{

	31 grid-column:2;

	32 grid-row:2;

	33 border-color: orange;

	34 }

	35 </style>

	36 </head>

	37

	38 <body>
	Manuel Rego 2016/07/20 06:00:23 In this case we clearly miss a description of the In this case we clearly miss a description of the expected result. Gleb Lanbin 2016/07/21 18:25:31 Done. Show quoted text On 2016/07/20 06:00:23, Manuel Rego wrote: > In this case we clearly miss a description of the expected result. Done.
	39 <fieldset class="grid">

	40 <legend>Fieldset with display: grid</legend>

	41 <div class="nw">NW</div>

	42 <div class="ne">NE</div>

	43 <div class="sw">SW</div>

	44 <div class="se">SE</div>

	45 </fieldset>

	46 </body>

	47 </html>

OLD	NEW