Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2149993004: Revert of Android: Add support for TraceEvent before the native library is loaded. (Closed)

Created:
4 years, 5 months ago by phoglund_chromium
Modified:
4 years, 5 months ago
Reviewers:
pasko, Benoit L, Yaron, jam, wychen
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Android: Add support for TraceEvent before the native library is loaded. (patchset #2 id:230001 of https://codereview.chromium.org/2142803002/ ) Reason for revert: This is breaking the WebRTC bots when we try to roll Chromium into WebRTC: https://codereview.webrtc.org/2147203002/ https://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/builds/14515 FAILED: lib/libwebrtc_nonparallel_tests.so ... error: undefined reference to 'base::android::RegisterEarlyTraceEvent(_JNIEnv*)' Original issue's description: > Reland of Android: Add support for TraceEvent before the native library is loaded. (patchset #1 id:1 of https://codereview.chromium.org/2145443002/ ) > > Reason for revert: > Reland. > > Original issue's description: > > Revert of Android: Add support for TraceEvent before the native library is loaded. (patchset #12 id:220001 of https://codereview.chromium.org/1486053003/ ) > > > > Reason for revert: > > https://crbug.com/627142 > > > > Original issue's description: > > > Android: Add support for TraceEvent before the native library is loaded. > > > > > > Currently TraceEvents recorded before the native library load are > > > silently discarded. This CL adds support for such "early" events. > > > > > > The events are buffered in Java, and then sent to the native side once > > > it is available. This support is intentionally simple now. The aim is to > > > ease performance investigation of early startup, and to ease tracking of > > > early startup performance regression, since timings are then accessible > > > to TBM tests. > > > > > > Also use the newly-introduced events in a couple places, and fix a bug > > > in the TraceEvent we use to record the launcher activity lifetime (when > > > an Activity calls finish from onCreate(), onPause() is not called). > > > > > > BUG=564041 > > > > > > Committed: https://crrev.com/fb0784294541c53f12e283124672750ab2e291f1 > > > Cr-Commit-Position: refs/heads/master@{#404635} > > > > TBR=pasko@chromium.org,yfriedman@chromium.org,jam@chromium.org,lizeb@chromium.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=564041 > > > > Committed: https://crrev.com/ffda73103b9a84e4739088175b9250a0c28e6f8c > > Cr-Commit-Position: refs/heads/master@{#404752} > > BUG=564041 > TBR=jam > > Committed: https://crrev.com/0267e3c29d74e8a4b0cab629206e14fa02ae2009 > Cr-Commit-Position: refs/heads/master@{#405120} TBR=pasko@chromium.org,yfriedman@chromium.org,jam@chromium.org,wychen@chromium.org,lizeb@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=564041 Committed: https://crrev.com/424329814fe672dd6e5c18d6e6aa6311b34f034b Cr-Commit-Position: refs/heads/master@{#405744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -439 lines) Patch
M base/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D base/android/early_trace_event_binding.h View 1 chunk +0 lines, -18 lines 0 comments Download
D base/android/early_trace_event_binding.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D base/android/java/src/org/chromium/base/EarlyTraceEvent.java View 1 chunk +0 lines, -179 lines 0 comments Download
M base/android/java/src/org/chromium/base/TraceEvent.java View 6 chunks +4 lines, -16 lines 0 comments Download
D base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java View 1 chunk +0 lines, -152 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 2 chunks +5 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
phoglund_chromium
Created Revert of Android: Add support for TraceEvent before the native library is loaded.
4 years, 5 months ago (2016-07-15 10:52:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149993004/1
4 years, 5 months ago (2016-07-15 10:52:25 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 12:00:19 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 12:02:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/424329814fe672dd6e5c18d6e6aa6311b34f034b
Cr-Commit-Position: refs/heads/master@{#405744}

Powered by Google App Engine
This is Rietveld 408576698