Issue 21499002: Get rid of HStringLength.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21499002: Get rid of HStringLength. (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
mvstanton, Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Get rid of HStringLength. Use HLoadNamedField to load the string length field instead. Depends on: https://codereview.chromium.org/21488002 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=16002

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -161 lines)			Patch
M	src/arm/lithium-arm.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/arm/lithium-arm.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/hydrogen.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	src/hydrogen.cc	View	4 chunks	+25 lines, -7 lines	0 comments	Download
M	src/hydrogen-instructions.h	View	7 chunks	+15 lines, -31 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	4 chunks	+13 lines, -11 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-ia32.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/mips/lithium-mips.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/x64/lithium-x64.h	View	2 chunks	+0 lines, -14 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View	1 chunk	+0 lines, -6 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

7 years, 4 months ago (2013-08-01 08:42:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r16002 (presubmit successful).