Issue 21488002: Fix broken HCheckInstanceType::Canonicalize().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 21488002: Fix broken HCheckInstanceType::Canonicalize(). (Closed)

Created:
7 years, 4 months ago by Benedikt Meurer

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

Benedikt Meurer

Hey Sven, Here's the fix for HCheckInstanceType::Canonicalize(). -- Benedikt

7 years, 4 months ago (2013-08-01 07:15:21 UTC) #1

danno

If this fixed something that was broken, can you please add a regression test?

7 years, 4 months ago (2013-08-01 07:44:47 UTC) #2

Benedikt Meurer

On 2013/08/01 07:44:47, danno wrote: > If this fixed something that was broken, can you ...

7 years, 4 months ago (2013-08-01 07:49:04 UTC) #3

Sven Panne

LGTM. Note: Adding a regression test is currently not possible, because the result of HCheckInstanceType ...

7 years, 4 months ago (2013-08-01 08:26:09 UTC) #4

Benedikt Meurer

7 years, 4 months ago (2013-08-01 08:27:51 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r15999 (presubmit successful).