go/src/infra/tricium/service/gerrit-reporter/handlers.go - Issue 2149853003: Adds checking of template error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/tricium/service/gerrit-reporter/handlers.go

Issue 2149853003: Adds checking of template error (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: go/src/infra/tricium/service/gerrit-reporter/handlers.go

diff --git a/go/src/infra/tricium/service/gerrit-reporter/handlers.go b/go/src/infra/tricium/service/gerrit-reporter/handlers.go

index ab9fee120bc0ae497aa4a3aeb9aad70cc091ac1d..083d3be335d801109680f86024ed6c8821d68faf 100644

--- a/go/src/infra/tricium/service/gerrit-reporter/handlers.go

+++ b/go/src/infra/tricium/service/gerrit-reporter/handlers.go

@@ -22,7 +22,10 @@ func statusPageHandler(w http.ResponseWriter, r *http.Request) {

data := map[string]interface{}{

"Msg": "Status of the Gerrit Reporter ...",

}

- basePage.Execute(w, data)

+ if e := basePage.Execute(w, data); e != nil {

+ http.Error(w, e.Error(), http.StatusInternalServerError)

+ return

+ }

}

func queueHandler(w http.ResponseWriter, r *http.Request) {