Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: go/src/infra/tricium/service/gerrit-poller/handlers.go

Issue 2149853003: Adds checking of template error (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/tricium/service/gerrit-poller/handlers.go
diff --git a/go/src/infra/tricium/service/gerrit-poller/handlers.go b/go/src/infra/tricium/service/gerrit-poller/handlers.go
index e9b14a09cd5b68052fdae72d2e05a2832d423f71..19919fed9a66f2307c1f940228d02cf8ada29b67 100644
--- a/go/src/infra/tricium/service/gerrit-poller/handlers.go
+++ b/go/src/infra/tricium/service/gerrit-poller/handlers.go
@@ -25,7 +25,10 @@ func statusPageHandler(w http.ResponseWriter, r *http.Request) {
data := map[string]interface{}{
"Msg": "Status of the Gerrit Poller ...",
}
- basePage.Execute(w, data)
+ if e := basePage.Execute(w, data); e != nil {
+ http.Error(w, e.Error(), http.StatusInternalServerError)
+ return
+ }
}
func pollHandler(w http.ResponseWriter, r *http.Request) {
@@ -35,8 +38,8 @@ func pollHandler(w http.ResponseWriter, r *http.Request) {
// Enqueue workflow event task.
t := taskqueue.NewPOSTTask("/workflow-launcher/queue-handler", map[string][]string{"name": {"Analysis Request"}})
- if _, err := taskqueue.Add(ctx, t, "workflow-launcher-queue"); err != nil {
- http.Error(w, err.Error(), http.StatusInternalServerError)
+ if _, e := taskqueue.Add(ctx, t, "workflow-launcher-queue"); e != nil {
+ http.Error(w, e.Error(), http.StatusInternalServerError)
return
}
}

Powered by Google App Engine
This is Rietveld 408576698