Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2149733002: Fix SkFixedDiv macro (Closed)

Created:
4 years, 5 months ago by liyuqian
Modified:
4 years, 5 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix SkFixedDiv macro Previously, the macro won't pass the unit test that I just added in this CL. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2149733002 Committed: https://skia.googlesource.com/skia/+/0d2c234e447d54110ee080d9f54ab347944393b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M include/private/SkFixed.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/MathTest.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
liyuqian
4 years, 5 months ago (2016-07-13 19:22:14 UTC) #3
caryclark
lgtm (since this is an include change, Mike must approve) But, why? Are you planning ...
4 years, 5 months ago (2016-07-13 19:29:45 UTC) #4
liyuqian
On 2016/07/13 19:29:45, caryclark wrote: > lgtm (since this is an include change, Mike must ...
4 years, 5 months ago (2016-07-13 19:35:20 UTC) #5
reed1
lgtm
4 years, 5 months ago (2016-07-13 20:09:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149733002/1
4 years, 5 months ago (2016-07-13 20:09:40 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:34:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0d2c234e447d54110ee080d9f54ab347944393b0

Powered by Google App Engine
This is Rietveld 408576698