include/private/SkFixed.h - Issue 2149733002: Fix SkFixedDiv macro

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/private/SkFixed.h

Issue 2149733002: Fix SkFixedDiv macro (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/private/SkFixed.h

diff --git a/include/private/SkFixed.h b/include/private/SkFixed.h

index 640f0e7ea3e1316f3d1139f3d6653bfaaed6a26c..be3bb5d6045d9b24fd98096295b3385be409d5d3 100644

--- a/include/private/SkFixed.h

+++ b/include/private/SkFixed.h

@@ -78,7 +78,7 @@ typedef int32_t SkFixed;

// The divide may exceed 32 bits. Clamp to a signed 32 bit result.

#define SkFixedDiv(numer, denom) \

- SkToS32(SkTPin<int64_t>((SkLeftShift((int64_t)numer, 16) / denom), SK_MinS32, SK_MaxS32))

+ SkToS32(SkTPin<int64_t>((SkLeftShift((int64_t)(numer), 16) / (denom)), SK_MinS32, SK_MaxS32))

//////////////////////////////////////////////////////////////////////////////////////////////////////

// Now look for ASM overrides for our portable versions (should consider putting this in its own file)

« no previous file with comments | « no previous file | tests/MathTest.cpp » ('j') | no next file with comments »