Use the Blank Page icon when editing a non-search Omnibox query.

Use the Blank Page icon when editing a non-search Omnibox query.

BUG=617887
Committed: https://crrev.com/79f10e462b13f6fafdbe2fe50b0eda048359fdf6
Cr-Commit-Position: refs/heads/master@{#407042}

[palmer, 2016-07-13 22:46:07]

palmer@chromium.org changed reviewers:
+ felt@chromium.org, pkasting@chromium.org

[palmer, 2016-07-13 22:46:07]

See if this looks like it's on the right track to you. If I understand the
result of the discussion in
https://bugs.chromium.org/p/chromium/issues/detail?id=617887, it seems to work
well for me.

[Peter Kasting, 2016-07-18 19:31:25]

LGTM

https://codereview.chromium.org/2149673003/diff/1/components/omnibox/browser/...
File components/omnibox/browser/omnibox_view.cc (right):

https://codereview.chromium.org/2149673003/diff/1/components/omnibox/browser/...
components/omnibox/browser/omnibox_view.cc:97: :
AutocompleteMatchType::URL_WHAT_YOU_TYPED);
Make sure this change doesn't change the omnibox icon when on the NTP.

[palmer, 2016-07-22 01:23:26]

> AutocompleteMatchType::URL_WHAT_YOU_TYPED);
> Make sure this change doesn't change the omnibox icon when on the NTP.

Good point; and, it's OK: the looking glass is still the omnibox icon.

[palmer, 2016-07-22 01:23:56]

The CQ bit was checked by palmer@chromium.org

[commit-bot: I haz the power, 2016-07-22 01:24:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 03:46:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-22 03:48:15]

Description was changed from

==========
Use the Blank Page icon when editing a non-search Omnibox query.

BUG=617887
==========

to

==========
Use the Blank Page icon when editing a non-search Omnibox query.

BUG=617887

Committed: https://crrev.com/79f10e462b13f6fafdbe2fe50b0eda048359fdf6
Cr-Commit-Position: refs/heads/master@{#407042}
==========

[commit-bot: I haz the power, 2016-07-22 03:48:16]

Patchset 1 (id:??) landed as
https://crrev.com/79f10e462b13f6fafdbe2fe50b0eda048359fdf6
Cr-Commit-Position: refs/heads/master@{#407042}