Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: components/omnibox/browser/omnibox_view.cc

Issue 2149673003: Use the Blank Page icon when editing a non-search Omnibox query. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/omnibox/browser/omnibox_view.cc
diff --git a/components/omnibox/browser/omnibox_view.cc b/components/omnibox/browser/omnibox_view.cc
index 1eb5bc9a63fb1328c898ce7527787f0baf2f6bb6..c92730f03337167fa96512a737b685be95034197 100644
--- a/components/omnibox/browser/omnibox_view.cc
+++ b/components/omnibox/browser/omnibox_view.cc
@@ -92,14 +92,9 @@ gfx::VectorIconId OmniboxView::GetVectorIcon() const {
if (!IsEditingOrEmpty())
return controller_->GetToolbarModel()->GetVectorIcon();
- // Reuse the dropdown icons...
- gfx::VectorIconId id = AutocompleteMatch::TypeToVectorIcon(
+ return AutocompleteMatch::TypeToVectorIcon(
model_ ? model_->CurrentTextType()
: AutocompleteMatchType::URL_WHAT_YOU_TYPED);
Peter Kasting 2016/07/18 19:31:25 Make sure this change doesn't change the omnibox i
- // but use a different version for the HTTP icon.
- return (id == gfx::VectorIconId::OMNIBOX_HTTP)
- ? gfx::VectorIconId::LOCATION_BAR_HTTP
- : id;
#else
NOTIMPLEMENTED();
return gfx::VectorIconId::VECTOR_ICON_NONE;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698