Support for figuring out the number of contexts in a page.

Support for figuring out the number of contexts in a page.

Turns out the number of contexts in the gaia page can be more than 15, so we need this.

Also fix a bug in cros_test_case where browser_options were not being properly set by the test.

BUG=361862
TEST=testIframe
NOTRY=True

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276380

[achuithb, 2014-03-28 16:11:55]

This CL returns the number of contexts available in a page, so the caller
doesn't have to guess.

Background context for this CL:
https://codereview.chromium.org/205763002/

Basically if we want to locate a particular iframe, we must first have to have a
rough idea of how many contexts to expect in the page, and iterate over that
many contexts. For the oobe screen, I've empirically found that 14 contexts are
created, so I just look for the gaia login iframe over 15 contexts.

Tim is uncomfortable with using a magic number, and prefers that WebContents
provide the number of contexts available.

This CL allows InspectorRuntime to return the number of contexts, but it
requires that you explicitly first call EnableAllContexts to get the number of
contexts, instead of simply calling EvaluateJavaScriptInContext and having it
implicitly call _EnableAllContexts.

I'm ambivalent towards both approaches (explicit vs implicit EnableAllContexts).
In the CL where I added support for iframes
(https://codereview.chromium.org/183863007/), Tony specifically directed me to
use implicit EnableAllContexts.

Tony - let me know your thoughts on how to proceed. Thank you!

[Tim Song, 2014-03-28 22:06:10]

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py
(right):

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:19:
self._max_context_id = max(self._max_context_id,
Is the max context id different than the total number of context ids?

[achuithb, 2014-03-28 23:38:36]

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py
(right):

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:19:
self._max_context_id = max(self._max_context_id,
On 2014/03/28 22:06:10, Tim Song wrote:
> Is the max context id different than the total number of context ids?

number of context ids = max context ids + 1.

Context id 0 is of the parent page.

[tonyg, 2014-03-31 15:01:32]

lgtm

If tests are happy, so am I.

[Tim Song, 2014-03-31 18:37:48]

lgtm

[achuithb, 2014-06-09 22:02:16]

I've reworked this CL.

Turns out this is necessary because gaia login contexts can be greater than our
hardcoded value of 15.

PTAL, Tim.

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py
(right):

https://codereview.chromium.org/214963004/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_runtime.py:19:
self._max_context_id = max(self._max_context_id,
On 2014/03/28 23:38:37, achuithb wrote:
> On 2014/03/28 22:06:10, Tim Song wrote:
> > Is the max context id different than the total number of context ids?
> 
> number of context ids = max context ids + 1.
> 
> Context id 0 is of the parent page.

This is incorrect: max_context_id = number of context_ids. Parent page context
id is 1.

[Tim Song, 2014-06-10 19:21:25]

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (right):

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:16: max_context_ids =
self.EnableAllContexts()
nit: for consistency with inspector_runtime.py
s/max_context_ids/max_context_id/

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:18: for gaia_context in
range(max_context_ids):
Shouldn't this be xrange(max_context_ids + 1) because max_context_ids is also a
valid context?

[achuithb, 2014-06-10 20:13:23]

Thanks for the feedback! PTAL, Tim.

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/oobe.py (right):

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:16: max_context_ids =
self.EnableAllContexts()
On 2014/06/10 19:21:25, Tim Song wrote:
> nit: for consistency with inspector_runtime.py
> s/max_context_ids/max_context_id/

Done.

https://codereview.chromium.org/214963004/diff/60001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/oobe.py:18: for gaia_context in
range(max_context_ids):
On 2014/06/10 19:21:25, Tim Song wrote:
> Shouldn't this be xrange(max_context_ids + 1) because max_context_ids is also
a
> valid context?

Done.

[Tim Song, 2014-06-10 20:41:25]

lgtm

[achuithb, 2014-06-10 20:43:23]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2014-06-10 20:43:43]

On 2014/06/10 20:41:25, Tim Song wrote:
> lgtm

Ty

[commit-bot: I haz the power, 2014-06-10 20:49:37]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/214963004/80001

[commit-bot: I haz the power, 2014-06-11 06:14:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-11 12:15:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 12:15:18]

Try jobs failed on following builders:
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[achuithb, 2014-06-11 13:29:14]

The CQ bit was checked by achuith@chromium.org

[commit-bot: I haz the power, 2014-06-11 13:31:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/achuith@chromium.org/214963004/80001

[commit-bot: I haz the power, 2014-06-11 13:33:17]

Change committed as 276380