tools/telemetry/telemetry/core/backends/chrome/oobe.py - Issue 214963004: Support for figuring out the number of contexts in a page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/oobe.py

Issue 214963004: Support for figuring out the number of contexts in a page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: max_context_id Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/backends/chrome/inspector_runtime_unittest.py ('k') | tools/telemetry/telemetry/core/web_contents.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/backends/chrome/oobe.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/oobe.py b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

index 9ca8ed3263b5a3c9d70518491b7ace6c6a619db9..38c642e7ef7e483ddffa135ce0671b47824f4f12 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/oobe.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/oobe.py

@@ -13,7 +13,9 @@ class Oobe(web_contents.WebContents):

super(Oobe, self).__init__(inspector_backend, backend_list)

def _GaiaLoginContext(self):

- for gaia_context in range(15):

+ max_context_id = self.EnableAllContexts()

+ logging.debug('%d contexts in Gaia page' % max_context_id)

+ for gaia_context in range(max_context_id + 1):

try:

if self.EvaluateJavaScriptInContext(

"document.readyState == 'complete' && "