Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2149493002: [turbofan] Introduce CheckedUint32Div and CheckUint32Mod operators. (Closed)

Created:
4 years, 5 months ago by Benedikt Meurer
Modified:
4 years, 5 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce CheckedUint32Div and CheckUint32Mod operators. Checked integer division and modulus can be done more efficiently if we know that the inputs are in Unsigned32 range. Drive-by-fix: Replace the TypeCheckKind on NodeInfo by a proper restriction type, and thread the feedback type through binary Number operations similar to what we do for their speculative versions. Also deal with Unsigned32 inputs for integer multiplication. R=jarin@chromium.org BUG=v8:4583, v8:5141 Committed: https://crrev.com/15ebec035f76512f1a6e0ec96d514ae3fa8532da Cr-Commit-Position: refs/heads/master@{#37703}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -118 lines) Patch
M src/compiler/effect-control-linearizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +50 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/representation-change.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/representation-change.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 24 chunks +101 lines, -118 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Benedikt Meurer
4 years, 5 months ago (2016-07-13 06:42:56 UTC) #1
Benedikt Meurer
Hey Jaro, Here are the SimplifiedLowering changes, that you helped me with. Please take a ...
4 years, 5 months ago (2016-07-13 06:43:50 UTC) #4
Jarin
lgtm, thanks! https://codereview.chromium.org/2149493002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2149493002/diff/1/src/compiler/simplified-lowering.cc#newcode1319 src/compiler/simplified-lowering.cc:1319: if (NodeProperties::GetType(node)->Is(Type::Unsigned32())) { As discussed offline, it ...
4 years, 5 months ago (2016-07-13 07:25:39 UTC) #7
Benedikt Meurer
https://codereview.chromium.org/2149493002/diff/1/src/compiler/simplified-lowering.cc File src/compiler/simplified-lowering.cc (right): https://codereview.chromium.org/2149493002/diff/1/src/compiler/simplified-lowering.cc#newcode1319 src/compiler/simplified-lowering.cc:1319: if (NodeProperties::GetType(node)->Is(Type::Unsigned32())) { On 2016/07/13 07:25:38, Jarin wrote: > ...
4 years, 5 months ago (2016-07-13 07:54:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149493002/20001
4 years, 5 months ago (2016-07-13 07:54:10 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 08:16:42 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 08:19:50 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/15ebec035f76512f1a6e0ec96d514ae3fa8532da
Cr-Commit-Position: refs/heads/master@{#37703}

Powered by Google App Engine
This is Rietveld 408576698