third_party/libpng/BUILD.gn - Issue 2149483002: Reduce chrome.exe .text size by 50 KB with static_library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libpng/BUILD.gn

Issue 2149483002: Reduce chrome.exe .text size by 50 KB with static_library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaking comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libpng/BUILD.gn

diff --git a/third_party/libpng/BUILD.gn b/third_party/libpng/BUILD.gn

index 7e4bd5e4048067059b18027feebda638e3d4a771..88a28cfaec2214bdb0e792b298273d5c8cea80f1 100644

--- a/third_party/libpng/BUILD.gn

+++ b/third_party/libpng/BUILD.gn

@@ -33,6 +33,7 @@ config("clang_warnings") {

}

+# Cannot be a static_library in component builds

Nico 2016/07/15 14:08:07 fwiw in gyp it's a component on windows and a stat

brucedawson 2016/07/15 18:08:54 Yep, and you can't pull a static_library with expo

source_set("libpng_sources") {

sources = [

"png.c",

« no previous file with comments | « third_party/brotli/BUILD.gn ('k') | ui/gfx/BUILD.gn » ('j') | no next file with comments »