Reduce chrome.exe .text size by 50 KB with static_library

third_party/libpng/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/arm.gni")
 
 config("libpng_config") {
   include_dirs = [ "." ]
 
@@ skipping 15 matching lines @@
   if (is_clang) {
     cflags = [
       # libpng checks that the width is not greater than PNG_SIZE_MAX.
       # On platforms where size_t is 64-bits, this comparison will always
       # be false.
       "-Wno-tautological-constant-out-of-range-compare",
     ]
   }
 }
 
+# Cannot be a static_library in component builds

[Nico, 2016/07/15 14:08:07]

fwiw in gyp it's a component on windows and a static library elsewhere

[brucedawson, 2016/07/15 18:08:54]

Yep, and you can't pull a static_library with exports into a DLL so on Windows
we would need to make it a source_set in component builds and a static_library
otherwise. I wasn't sure if it was worth the extra complexity for the 17 .obj
files that this represents.

 source_set("libpng_sources") {
   sources = [
     "png.c",
     "png.h",
     "pngconf.h",
     "pngerror.c",
     "pngget.c",
     "pnginfo.h",
     "pnglibconf.h",
     "pngmem.c",
@@ skipping 60 matching lines @@
       ":libpng_sources",
     ]
   }
 } else {
   group("libpng") {
     public_deps = [
       ":libpng_sources",
     ]
   }
 }