components/browser_watcher/BUILD.gn - Issue 2149483002: Reduce chrome.exe .text size by 50 KB with static_library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/browser_watcher/BUILD.gn

Issue 2149483002: Reduce chrome.exe .text size by 50 KB with static_library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tweaking comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/browser_watcher/BUILD.gn

diff --git a/components/browser_watcher/BUILD.gn b/components/browser_watcher/BUILD.gn

index 8b95bcd060a1e9a1169703ead63d885b0cd276ef..883daece472ef5a8e9064c040f27a064d18a4e42 100644

--- a/components/browser_watcher/BUILD.gn

+++ b/components/browser_watcher/BUILD.gn

@@ -2,7 +2,7 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-source_set("browser_watcher") {

+static_library("browser_watcher") {

# This is a separate lib to minimize the dependencies for its

# hosting binary "chrome_watcher.dll".

sources = [

@@ -20,7 +20,7 @@ source_set("browser_watcher") {

]

}

-source_set("browser_watcher_client") {

+static_library("browser_watcher_client") {

sources = [

"watcher_client_win.cc",

"watcher_client_win.h",

« no previous file with comments | « components/bookmarks/common/BUILD.gn ('k') | components/crash/content/app/BUILD.gn » ('j') | third_party/libpng/BUILD.gn » ('J')