Implement first version of OfflinePageSuggestionsProvider

chrome/browser/android/chrome_feature_list.cc

Index: chrome/browser/android/chrome_feature_list.cc
diff --git a/chrome/browser/android/chrome_feature_list.cc b/chrome/browser/android/chrome_feature_list.cc
index 5183b9b28a5ecad464f40272b88489e8d3758781..e577fa25e5cd0916f8ddd78f490e2e3c83d8818d 100644
--- a/chrome/browser/android/chrome_feature_list.cc
+++ b/chrome/browser/android/chrome_feature_list.cc
@@ -36,6 +36,7 @@ const base::Feature* kFeaturesExposedToJava[] = {
     &kNTPMaterialDesign,
     &kNTPOfflinePagesFeature,
     &kNTPSnippetsFeature,
+    &kNTPOfflinePageSuggestionsFeature,
     &kNTPToolbarFeature,
     &kPhysicalWebFeature,
     &kPhysicalWebIgnoreOtherClientsFeature,
@@ -61,6 +62,9 @@ const base::Feature kNTPSnippetsFeature {
   "NTPSnippets", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
+const base::Feature kNTPOfflinePageSuggestionsFeature{
+    "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};

[Marc Treib, 2016/07/14 12:16:53]

nit: this is formatted differently than all the other entries

[Philipp Keck, 2016/07/14 13:46:02]

This is "git cl" formatted. Both the seemingly missing space before "{" and the
missing newline before "}" are what the formatter does, so they are removed if
they're there. Something similar would happen to all the others, if I changed
them.

Actually I had a similar problem with about_flags.cc, where quite a few lines
that I never touched change every time I run "git cl format".

[Marc Treib, 2016/07/14 16:13:16]

Can we stay consistent with how the rest of the entries are formatted?
Consistency over git cl format.
(Or alternatively, re-format everything...)

[Philipp Keck, 2016/07/15 09:08:41]

Ok. For about_flags.cc, I don't want to reformat the whole file, so I will keep
undoing the auto-formatter when working on this CL, even though that's annoying.

For this file, I adjust everything the way the formatter does it.

+
 const base::Feature kNTPToolbarFeature {
   "NTPToolbar", base::FEATURE_ENABLED_BY_DEFAULT
 };