Implement first version of OfflinePageSuggestionsProvider

chrome/browser/android/chrome_feature_list.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/chrome_feature_list.h"
 
 #include <stddef.h>
 
 #include <string>
 
@@ skipping 18 matching lines @@
 const base::Feature* kFeaturesExposedToJava[] = {
     &features::kAutoplayMutedVideos,
     &features::kCredentialManagementAPI,
     &features::kSimplifiedFullscreenUI,
     &kAndroidPayIntegrationV1,
     &kImportantSitesInCBD,
     &kNTPFakeOmniboxTextFeature,
     &kNTPMaterialDesign,
     &kNTPOfflinePagesFeature,
     &kNTPSnippetsFeature,
+    &kNTPOfflinePageSuggestionsFeature,
     &kNTPToolbarFeature,
     &kPhysicalWebFeature,
     &kPhysicalWebIgnoreOtherClientsFeature,
     &kReadItLaterInMenu,
     &kSystemDownloadManager,
     &offline_pages::kOfflinePagesBackgroundLoadingFeature,
     &offline_pages::kOfflinePagesCTFeature,  // See crbug.com/620421.
 };
 
 }  // namespace
 
 const base::Feature kImportantSitesInCBD{"ImportantSitesInCBD",
                                          base::FEATURE_DISABLED_BY_DEFAULT};
 
 const base::Feature kNTPMaterialDesign{"NTPMaterialDesign",
                                        base::FEATURE_ENABLED_BY_DEFAULT};
 
 const base::Feature kNTPOfflinePagesFeature {
   "NTPOfflinePages", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
 const base::Feature kNTPSnippetsFeature {
   "NTPSnippets", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
+const base::Feature kNTPOfflinePageSuggestionsFeature{
+    "NTPOfflinePageSuggestions", base::FEATURE_DISABLED_BY_DEFAULT};

[Marc Treib, 2016/07/14 12:16:53]

nit: this is formatted differently than all the other entries

[Philipp Keck, 2016/07/14 13:46:02]

This is "git cl" formatted. Both the seemingly missing space before "{" and the
missing newline before "}" are what the formatter does, so they are removed if
they're there. Something similar would happen to all the others, if I changed
them.

Actually I had a similar problem with about_flags.cc, where quite a few lines
that I never touched change every time I run "git cl format".

[Marc Treib, 2016/07/14 16:13:16]

Can we stay consistent with how the rest of the entries are formatted?
Consistency over git cl format.
(Or alternatively, re-format everything...)

[Philipp Keck, 2016/07/15 09:08:41]

Ok. For about_flags.cc, I don't want to reformat the whole file, so I will keep
undoing the auto-formatter when working on this CL, even though that's annoying.

For this file, I adjust everything the way the formatter does it.

+
 const base::Feature kNTPToolbarFeature {
   "NTPToolbar", base::FEATURE_ENABLED_BY_DEFAULT
 };
 
 const base::Feature kNTPFakeOmniboxTextFeature {
   "NTPFakeOmniboxText", base::FEATURE_DISABLED_BY_DEFAULT
 };
 
 const base::Feature kAndroidPayIntegrationV1 {
   "AndroidPayIntegrationV1", base::FEATURE_ENABLED_BY_DEFAULT
@@ skipping 27 matching lines @@
   NOTREACHED();
   return false;
 }
 
 bool RegisterChromeFeatureListJni(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android
 }  // namespace chrome