Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 2149453002: When fetching try jobs for a CL, include only the latest for each builder. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 4 months ago
CC:
blink-reviews, cbentzel+watch_chromium.org, chromium-reviews, dcampb, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When fetching try jobs for a CL, include only the latest for each builder. This changes webkitpy.common.net.rietveld.latest_try_jobs to return only the latest try job for each builder on the latest patchset; previously it would return all try jobs for the latest patchset, even if there are multiple retries for the same builder. This is the behavior I believe we want for rebaselining from try jobs, because if some flaky tests fail in a try job on one try, that builder can be retried, and then new baselines should be downloaded only for the latest run for that builder. BUG=474273 Committed: https://crrev.com/a8fa41e4ad43d97dff7184069da9d169b3cd1aab Cr-Commit-Position: refs/heads/master@{#405796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py View 3 chunks +20 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py View 2 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
qyearsley
4 years, 5 months ago (2016-07-13 03:28:39 UTC) #2
wkorman
lgtm
4 years, 5 months ago (2016-07-15 00:19:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149453002/1
4 years, 5 months ago (2016-07-15 17:25:00 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 18:20:25 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a8fa41e4ad43d97dff7184069da9d169b3cd1aab Cr-Commit-Position: refs/heads/master@{#405796}
4 years, 5 months ago (2016-07-15 18:23:27 UTC) #12
Dirk Pranke
4 years, 4 months ago (2016-08-09 04:01:56 UTC) #13
Message was sent while issue was closed.
lgtm (very belatedly).

Powered by Google App Engine
This is Rietveld 408576698