Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py

Issue 2149453002: When fetching try jobs for a CL, include only the latest for each builder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
index f4fa65598cd2b697be774781cd30a392c7ddf114..c32b741243f9f554a00b3f8162120f45a5216559 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld_unittest.py
@@ -7,7 +7,10 @@ import logging
import unittest
import urllib2
-from webkitpy.common.net.rietveld import latest_try_jobs, TryJob, get_latest_try_job_results
+from webkitpy.common.net.rietveld import filter_latest_jobs
+from webkitpy.common.net.rietveld import get_latest_try_job_results
+from webkitpy.common.net.rietveld import latest_try_jobs
+from webkitpy.common.net.rietveld import TryJob
from webkitpy.common.net.web_mock import MockWeb
from webkitpy.common.system.outputcapture import OutputCapture
@@ -89,3 +92,30 @@ class RietveldTest(unittest.TestCase):
def test_get_latest_try_job_results(self):
self.assertEqual(get_latest_try_job_results(11112222, self.web), {'foo-builder': 1, 'bar-builder': 0})
+
+ def test_filter_latest_jobs_empty(self):
+ self.assertEqual(filter_latest_jobs([]), [])
+
+ def test_filter_latest_jobs_higher_build_first(self):
+ self.assertEqual(
+ filter_latest_jobs([
+ TryJob('foo', 5),
+ TryJob('foo', 3),
+ TryJob('bar', 5),
+ ]),
+ [
+ TryJob('foo', 5),
+ TryJob('bar', 5),
+ ])
+
+ def test_filter_latest_jobs_higher_build_last(self):
+ self.assertEqual(
+ filter_latest_jobs([
+ TryJob('foo', 3),
+ TryJob('bar', 5),
+ TryJob('foo', 5),
+ ]),
+ [
+ TryJob('bar', 5),
+ TryJob('foo', 5),
+ ])
« no previous file with comments | « third_party/WebKit/Tools/Scripts/webkitpy/common/net/rietveld.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698