Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 2149233005: Fix bug with 'not' flags in _FormatSource() (Closed)

Created:
4 years, 5 months ago by Greg Levin
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix bug with 'not' flags in _FormatSource() BUG=628086 TEST=See bug, check that logo has reappeared. Alternately, run in debug mode and observe that program doesn't crash at startup. Committed: https://crrev.com/1be5656fff449c3d2ad654c21fb33df30e4becea Cr-Commit-Position: refs/heads/master@{#405892}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move line as per review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/grit/grit/format/resource_map.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Greg Levin
Hey thestig@. Could you take a look at this? This appears to fix things, but ...
4 years, 5 months ago (2016-07-15 17:54:28 UTC) #2
Lei Zhang
Thanks for tracking this down. Will take a look in a bit. I'm not 100% ...
4 years, 5 months ago (2016-07-15 19:42:39 UTC) #3
Lei Zhang
lgtm, thanks again. I'll look into writing a grit unit test. https://codereview.chromium.org/2149233005/diff/1/tools/grit/grit/format/resource_map.py File tools/grit/grit/format/resource_map.py (right): ...
4 years, 5 months ago (2016-07-15 21:41:06 UTC) #4
Greg Levin
https://codereview.chromium.org/2149233005/diff/1/tools/grit/grit/format/resource_map.py File tools/grit/grit/format/resource_map.py (right): https://codereview.chromium.org/2149233005/diff/1/tools/grit/grit/format/resource_map.py#newcode126 tools/grit/grit/format/resource_map.py:126: seen.add(key) On 2016/07/15 21:41:06, Lei Zhang wrote: > Put ...
4 years, 5 months ago (2016-07-15 22:29:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149233005/20001
4 years, 5 months ago (2016-07-15 22:29:26 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 23:10:29 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 23:10:40 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 23:12:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1be5656fff449c3d2ad654c21fb33df30e4becea
Cr-Commit-Position: refs/heads/master@{#405892}

Powered by Google App Engine
This is Rietveld 408576698