tools/grit/grit/format/resource_map.py - Issue 2149233005: Fix bug with 'not' flags in _FormatSource()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/grit/grit/format/resource_map.py

Issue 2149233005: Fix bug with 'not' flags in _FormatSource() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Move line as per review Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/grit/grit/format/resource_map.py

diff --git a/tools/grit/grit/format/resource_map.py b/tools/grit/grit/format/resource_map.py

index aca9f7f138b3dcac62bb9147ca6cc6e80796d794..e48182cab1c2907731e51dbe25e410ec2c3a32c8 100755

--- a/tools/grit/grit/format/resource_map.py

+++ b/tools/grit/grit/format/resource_map.py

@@ -120,9 +120,9 @@ def _FormatSource(get_key, root, lang, output_dir):

tid = item.attrs['name']

if tid not in tids or key in seen:

continue

- seen.add(key)

if item.GeneratesResourceMapEntry(output_all_resource_defines,

item in active_descendants):

+ seen.add(key)

yield ' {"%s", %s},\n' % (key, tid)

yield _FormatSourceFooter(root)

« no previous file with comments | « no previous file | no next file » | no next file with comments »