Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2149203003: DevTools: WI.SourceCodeDiff should not depend on UISourceCode (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
einbinder, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: WI.SourceCodeDiff should not depend on UISourceCode WI.SourceCodeDiff is simply a text editor decorator; it should rely solely on text editor events to updates itself. BUG=none R=dgozman, einbinder Committed: https://crrev.com/a317b4aa0f9ba44397ea709e3ed8aeb2b5766db2 Cr-Commit-Position: refs/heads/master@{#405757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js View 2 chunks +5 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js View 6 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-15 01:07:43 UTC) #1
dgozman
lgtm
4 years, 5 months ago (2016-07-15 01:14:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149203003/1
4 years, 5 months ago (2016-07-15 15:07:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 15:12:23 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 15:12:38 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 15:14:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a317b4aa0f9ba44397ea709e3ed8aeb2b5766db2
Cr-Commit-Position: refs/heads/master@{#405757}

Powered by Google App Engine
This is Rietveld 408576698