Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js

Issue 2149203003: DevTools: WI.SourceCodeDiff should not depend on UISourceCode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js b/third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js
index 752d8c4de71961444f99fa0bf910a67888683f19..c282887164e19e0dbadcbc07cdf98335eb9d3554 100644
--- a/third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js
+++ b/third_party/WebKit/Source/devtools/front_end/sources/SourceCodeDiff.js
@@ -4,16 +4,15 @@
/**
* @constructor
- * @param {!WebInspector.UISourceCode} uiSourceCode
+ * @param {!Promise<?string>} diffBaseline
* @param {!WebInspector.CodeMirrorTextEditor} textEditor
*/
-WebInspector.SourceCodeDiff = function(uiSourceCode, textEditor)
+WebInspector.SourceCodeDiff = function(diffBaseline, textEditor)
{
- this._uiSourceCode = uiSourceCode;
this._textEditor = textEditor;
this._decorations = [];
this._textEditor.installGutter(WebInspector.SourceCodeDiff.DiffGutterType, true);
- this._diffBaseline = this._uiSourceCode.requestOriginalContent();
+ this._diffBaseline = diffBaseline;
/** @type {!Array<!WebInspector.TextEditorPositionHandle>}*/
this._animatedLines = [];
}
@@ -193,8 +192,8 @@ WebInspector.SourceCodeDiff.prototype = {
*/
_innerUpdate: function(baseline)
{
- var current = this._uiSourceCode.workingCopy();
- if (typeof current !== "string" || typeof baseline !== "string") {
+ var current = this._textEditor.text();
+ if (typeof baseline !== "string") {
this._updateDecorations(this._decorations, [] /* added */);
this._decorations = [];
return;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/sources/UISourceCodeFrame.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698