Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 2149203002: Update HistoryController::current_entry_ on all main frame back/forwards. (Closed)

Created:
2 years, 7 months ago by Charlie Reis
Modified:
2 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

Update HistoryController::current_entry_ on all main frame back/forwards. This fixes a case where it was left stale on a cross-origin commit because the provisional_entry_ had been cleared by a different commit. BUG=623319 TEST=See bug comment 14 for repro steps. CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2134493002 Cr-Commit-Position: refs/heads/master@{#404537} (cherry picked from commit ab22bdfc5cb681f2f4dc789171e97618a9657486) Committed: https://chromium.googlesource.com/chromium/src/+/ee471f56c04351e46c360722ad813a141dba79fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -1 line) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +85 lines, -0 lines 0 comments Download
M content/renderer/history_controller.cc View 1 chunk +22 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Charlie Reis
2 years, 7 months ago (2016-07-14 21:01:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ee471f56c04351e46c360722ad813a141dba79fb.

Powered by Google App Engine
This is Rietveld 408576698