Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 2149193002: Sending the time of the pingback request in the request (Closed)

Created:
4 years, 5 months ago by RyanSturm
Modified:
4 years, 5 months ago
Reviewers:
tbansal1
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sending the time of the pingback request in the request Because a client can change their clock at any time, it is useful to have the client's view of the current time when the request is started. BUG=618867 Committed: https://crrev.com/dc0e4f4f0b1ba0db6dd2ee7c03ad7281262d144c Cr-Commit-Position: refs/heads/master@{#405817}

Patch Set 1 #

Total comments: 10

Patch Set 2 : tbansal comments #

Patch Set 3 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -16 lines) Patch
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.h View 1 2 chunks +12 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc View 4 chunks +37 lines, -13 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc View 1 2 2 chunks +19 lines, -1 line 0 comments Download
M components/data_reduction_proxy/proto/pageload_metrics.proto View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
RyanSturm
tbansal: PTAL @ *, thanks
4 years, 5 months ago (2016-07-14 22:01:57 UTC) #6
tbansal1
lgtm % comments below. https://codereview.chromium.org/2149193002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc (right): https://codereview.chromium.org/2149193002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc#newcode73 components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc:73: return batched_request; return std::move(batched_request); e.g., ...
4 years, 5 months ago (2016-07-15 17:44:04 UTC) #9
RyanSturm
https://codereview.chromium.org/2149193002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc File components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc (right): https://codereview.chromium.org/2149193002/diff/1/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc#newcode73 components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc:73: return batched_request; On 2016/07/15 17:44:04, tbansal1 wrote: > return ...
4 years, 5 months ago (2016-07-15 18:16:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149193002/40001
4 years, 5 months ago (2016-07-15 19:19:47 UTC) #21
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-15 19:25:26 UTC) #22
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 19:25:30 UTC) #23
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 19:29:07 UTC) #25
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dc0e4f4f0b1ba0db6dd2ee7c03ad7281262d144c
Cr-Commit-Position: refs/heads/master@{#405817}

Powered by Google App Engine
This is Rietveld 408576698