Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mild cleanup Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/PageOverlayTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index fd50765a3d526faa0323d6805470ffd402e00f3a..c9092d404c61819019db9093503bc8261cad5f0c 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -315,10 +315,6 @@ public:
{
}
- virtual ~ColorOverlay()
- {
- }
-
private:
void paintPageOverlay(const PageOverlay& pageOverlay, GraphicsContext& graphicsContext, const WebSize& size) const override
{
@@ -4154,7 +4150,7 @@ void WebViewImpl::setPageOverlayColor(WebColor color)
if (color == Color::transparent)
return;
- m_pageColorOverlay = PageOverlay::create(this, new ColorOverlay(color));
+ m_pageColorOverlay = PageOverlay::create(this, wrapUnique(new ColorOverlay(color)));
m_pageColorOverlay->update();
}
« no previous file with comments | « third_party/WebKit/Source/web/PageOverlayTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698