third_party/WebKit/Source/web/PageOverlayTest.cpp - Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageOverlayTest.cpp

Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mild cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PageOverlayTest.cpp

diff --git a/third_party/WebKit/Source/web/PageOverlayTest.cpp b/third_party/WebKit/Source/web/PageOverlayTest.cpp

index 5e1ed682da688d835b397d5656d39ff8f0b776a8..579dd52e6448960c33343ceb4b53aef9b7f550fb 100644

--- a/third_party/WebKit/Source/web/PageOverlayTest.cpp

+++ b/third_party/WebKit/Source/web/PageOverlayTest.cpp

@@ -82,7 +82,7 @@ protected:

std::unique_ptr<PageOverlay> createSolidYellowOverlay()

{

- return PageOverlay::create(webViewImpl(), new SolidColorOverlay(SK_ColorYELLOW));

+ return PageOverlay::create(webViewImpl(), wrapUnique(new SolidColorOverlay(SK_ColorYELLOW)));

}

template <typename OverlayType>