third_party/WebKit/Source/web/PageOverlay.cpp - Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/PageOverlay.cpp

Issue 2149143002: Move PageOverlay::Delegate off the Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mild cleanup Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/PageOverlay.cpp

diff --git a/third_party/WebKit/Source/web/PageOverlay.cpp b/third_party/WebKit/Source/web/PageOverlay.cpp

index e113b7fedaa56ef73f5595da285f60279eb83e27..21de6c5d79d9338303b80b81b5e42e91bf6a9881 100644

--- a/third_party/WebKit/Source/web/PageOverlay.cpp

+++ b/third_party/WebKit/Source/web/PageOverlay.cpp

@@ -45,14 +45,14 @@

namespace blink {

-std::unique_ptr<PageOverlay> PageOverlay::create(WebViewImpl* viewImpl, PageOverlay::Delegate* delegate)

+std::unique_ptr<PageOverlay> PageOverlay::create(WebViewImpl* viewImpl, std::unique_ptr<PageOverlay::Delegate> delegate)

{

- return wrapUnique(new PageOverlay(viewImpl, delegate));

+ return wrapUnique(new PageOverlay(viewImpl, std::move(delegate)));

}

-PageOverlay::PageOverlay(WebViewImpl* viewImpl, PageOverlay::Delegate* delegate)

+PageOverlay::PageOverlay(WebViewImpl* viewImpl, std::unique_ptr<PageOverlay::Delegate> delegate)

: m_viewImpl(viewImpl)

- , m_delegate(delegate)

+ , m_delegate(std::move(delegate))

{

}