Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 214913005: Adds bench expectations to expectations/bench; fixes bench alert test's dependency on script line n… (Closed)

Created:
6 years, 9 months ago by benchen
Modified:
6 years, 9 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, skiabot_google.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Adds bench expectations to expectations/bench; fixes bench alert test's dependency on script line number. BUG=skia:2307 NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13979

Patch Set 1 #

Messages

Total messages: 6 (0 generated)
benchen
Next step is to "revert" buildbot/slave/skia_slave_scripts/check_for_regressions.py but point to the new expectations location. CL to ...
6 years, 9 months ago (2014-03-27 19:39:08 UTC) #1
borenet
These are just copied from skia-autogen? If so, LGTM.
6 years, 9 months ago (2014-03-27 21:08:17 UTC) #2
benchen
On 2014/03/27 21:08:17, borenet wrote: > These are just copied from skia-autogen? If so, LGTM. ...
6 years, 9 months ago (2014-03-27 21:20:32 UTC) #3
benchen
The CQ bit was checked by bensong@google.com
6 years, 9 months ago (2014-03-28 17:55:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bensong@google.com/214913005/1
6 years, 9 months ago (2014-03-28 17:55:33 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-28 17:55:59 UTC) #6
Message was sent while issue was closed.
Change committed as 13979

Powered by Google App Engine
This is Rietveld 408576698