Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: bench/check_bench_regressions.py

Issue 214913005: Adds bench expectations to expectations/bench; fixes bench alert test's dependency on script line n… (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | expectations/bench/bench_expectations_Perf-Android-Nexus10-MaliT604-Arm7-Release.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: bench/check_bench_regressions.py
diff --git a/bench/check_bench_regressions.py b/bench/check_bench_regressions.py
index 8f648dc2b0f23cdbb05b721619c10163af8e96d4..86ead549579eb49de9d2b4ecc094769d34d8ca74 100644
--- a/bench/check_bench_regressions.py
+++ b/bench/check_bench_regressions.py
@@ -175,7 +175,11 @@ def check_expectations(lines, expectations, key_suffix):
outputs.extend(['', header] + li)
if outputs:
- raise Exception('\n'.join(outputs))
+ # Directly raising Exception will have stderr outputs tied to the line
+ # number of the script, so use sys.stderr.write() instead.
+ # Add a trailing newline to supress new line checking errors.
+ sys.stderr.write('\n'.join(['Exception:'] + outputs + ['\n']))
+ exit(1)
def main():
« no previous file with comments | « no previous file | expectations/bench/bench_expectations_Perf-Android-Nexus10-MaliT604-Arm7-Release.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698