Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 2149033003: IntersectionObserver: send notifications when objects disappear. (Closed)

Created:
4 years, 5 months ago by szager1
Modified:
4 years, 5 months ago
Reviewers:
eae
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IntersectionObserver: send notifications when objects disappear. TEST=intersection-observer/display-none.html BUG=621693 R=eae@chromium.org Committed: https://crrev.com/39fcf43a4bee8f0b15abf4ef8100c2612dd45cb2 Cr-Commit-Position: refs/heads/master@{#405630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -47 lines) Patch
A + third_party/WebKit/LayoutTests/intersection-observer/display-none.html View 3 chunks +35 lines, -29 lines 0 comments Download
A + third_party/WebKit/LayoutTests/intersection-observer/display-none-expected.txt View 2 chunks +15 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/core/dom/IntersectionObservation.cpp View 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
szager1
4 years, 5 months ago (2016-07-14 22:26:38 UTC) #1
eae
LGTM
4 years, 5 months ago (2016-07-14 22:27:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2149033003/1
4 years, 5 months ago (2016-07-14 22:29:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-14 23:43:53 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-14 23:46:05 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/39fcf43a4bee8f0b15abf4ef8100c2612dd45cb2
Cr-Commit-Position: refs/heads/master@{#405630}

Powered by Google App Engine
This is Rietveld 408576698