Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/intersection-observer/display-none.html

Issue 2149033003: IntersectionObserver: send notifications when objects disappear. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/display-none-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/intersection-observer/display-none.html
diff --git a/third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html b/third_party/WebKit/LayoutTests/intersection-observer/display-none.html
similarity index 72%
copy from third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html
copy to third_party/WebKit/LayoutTests/intersection-observer/display-none.html
index 990be02ebb9ed4b0aecff01da1ca13eb64b19df7..df0541adf055888b7fd9acbbf416401b6d4f6996 100644
--- a/third_party/WebKit/LayoutTests/intersection-observer/same-document-root.html
+++ b/third_party/WebKit/LayoutTests/intersection-observer/display-none.html
@@ -1,15 +1,29 @@
<!DOCTYPE html>
<script src="../resources/js-test.js"></script>
<script src="../resources/intersection-observer-helper-functions.js"></script>
+<style>
+#root {
+ display: inline-block;
+ overflow-y: scroll;
+ height: 200px;
+ border: 3px solid black;
+}
+#target {
+ background-color: green;
+ width: 100px;
+ height: 100px;
+}
+</style>
<div style="width:100%; height:700px;"></div>
-<div id="root" style="display: inline-block; overflow-y: scroll; height: 200px; border: 3px solid black">
+<div id="root">
<div style="width:100px; height: 300px;"></div>
- <div id="target" style="background-color: green; width:100px; height:100px"></div>
+ <div id="target"></div>
+ <div style="width:100%;height:700px;"></div>
</div>
<div style="width:100%;height:700px;"></div>
<script>
-description("Simple intersection observer test with explicit root and target in the same document.");
+description("Test that setting display:none will send a not-intersecting notification.");
var target = document.getElementById("target");
var root = document.getElementById("root");
var entries = [];
@@ -25,7 +39,6 @@ onload = function() {
waitForNotification(step0);
}
-// Test that notifications are not generated when the target is overflow clipped by the root.
function step0() {
shouldBeEqualToNumber("entries.length", 0);
document.scrollingElement.scrollTop = 600;
@@ -55,53 +68,46 @@ function step2() {
shouldBeEqualToNumber("entries[0].rootBounds.bottom", 311);
shouldEvaluateToSameObject("entries[0].target", target);
}
- document.scrollingElement.scrollTop = 0;
+ target.style.display = "none";
waitForNotification(step3);
}
function step3() {
- shouldBeEqualToNumber("entries.length", 1);
- root.scrollTop = 0;
- waitForNotification(step4);
-}
-
-function step4() {
shouldBeEqualToNumber("entries.length", 2);
if (entries.length > 1) {
- shouldBeEqualToNumber("entries[1].boundingClientRect.left", 11);
- shouldBeEqualToNumber("entries[1].boundingClientRect.right", 111);
- shouldBeEqualToNumber("entries[1].boundingClientRect.top", 1011);
- shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 1111);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.left", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.right", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.top", 0);
+ shouldBeEqualToNumber("entries[1].boundingClientRect.bottom", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.left", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.right", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.top", 0);
shouldBeEqualToNumber("entries[1].intersectionRect.bottom", 0);
- shouldBeEqualToNumber("entries[1].rootBounds.left", 11);
- shouldBeEqualToNumber("entries[1].rootBounds.right", 111);
- shouldBeEqualToNumber("entries[1].rootBounds.top", 711);
- shouldBeEqualToNumber("entries[1].rootBounds.bottom", 911);
+ shouldBeEqualToNumber("entries[1].rootBounds.left", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.right", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.top", 0);
+ shouldBeEqualToNumber("entries[1].rootBounds.bottom", 0);
shouldEvaluateToSameObject("entries[1].target", target);
}
- root.scrollTop = 150;
- waitForNotification(step5);
+ target.style.display = "";
+ waitForNotification(step4);
}
-// This tests that notifications are generated even when the root element is off screen.
-function step5() {
+function step4() {
shouldBeEqualToNumber("entries.length", 3);
if (entries.length > 2) {
shouldBeEqualToNumber("entries[2].boundingClientRect.left", 11);
shouldBeEqualToNumber("entries[2].boundingClientRect.right", 111);
- shouldBeEqualToNumber("entries[2].boundingClientRect.top", 861);
- shouldBeEqualToNumber("entries[2].boundingClientRect.bottom", 961);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.top", 261);
+ shouldBeEqualToNumber("entries[2].boundingClientRect.bottom", 361);
shouldBeEqualToNumber("entries[2].intersectionRect.left", 11);
shouldBeEqualToNumber("entries[2].intersectionRect.right", 111);
- shouldBeEqualToNumber("entries[2].intersectionRect.top", 861);
- shouldBeEqualToNumber("entries[2].intersectionRect.bottom", 911);
+ shouldBeEqualToNumber("entries[2].intersectionRect.top", 261);
+ shouldBeEqualToNumber("entries[2].intersectionRect.bottom", 311);
shouldBeEqualToNumber("entries[2].rootBounds.left", 11);
shouldBeEqualToNumber("entries[2].rootBounds.right", 111);
- shouldBeEqualToNumber("entries[2].rootBounds.top", 711);
- shouldBeEqualToNumber("entries[2].rootBounds.bottom", 911);
+ shouldBeEqualToNumber("entries[2].rootBounds.top", 111);
+ shouldBeEqualToNumber("entries[2].rootBounds.bottom", 311);
shouldEvaluateToSameObject("entries[2].target", target);
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/intersection-observer/display-none-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698