VM: Array bounds checks that don't deoptimize for precompiled code.

VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=rmacnak@google.com, vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
Committed: https://github.com/dart-lang/sdk/commit/d3810213b0b185fc2fb9a6239f1f67fbb72e63b0

[Florian Schneider, 2016-07-13 23:53:20]

fschneider@google.com changed reviewers:
+ vegorov@google.com

[Vyacheslav Egorov (Google), 2016-07-14 09:36:00]

lgtm

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:106: // Throw: new ArgumentError.value(length,
"length", "is not an integer");
comment should say index.

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:121: 
+1 empty line

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_mips.cc:4919: __ andi(CMPRES1, index,
Immediate(kSmiTagMask));
I wonder if assembler could benefit from BranchIfSmi or something like that.

[Florian Schneider, 2016-07-14 17:05:22]

Ptal. Also fixed ia32 where I forgot to change CheckArrayBoundInstr to include
the smi-check.

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:106: // Throw: new ArgumentError.value(length,
"length", "is not an integer");
On 2016/07/14 09:35:59, Vyacheslav Egorov (Google) wrote:
> comment should say index.

Done.

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/code_generat...
runtime/vm/code_generator.cc:121: 
On 2016/07/14 09:35:59, Vyacheslav Egorov (Google) wrote:
> +1 empty line

Done.

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_mips.cc (right):

https://codereview.chromium.org/2149023002/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_mips.cc:4919: __ andi(CMPRES1, index,
Immediate(kSmiTagMask));
On 2016/07/14 09:35:59, Vyacheslav Egorov (Google) wrote:
> I wonder if assembler could benefit from BranchIfSmi or something like that.

Ya, I wished that too.

I'll add BranchIfNotSmi and BranchIfSmi.

[Vyacheslav Egorov (Google), 2016-07-14 17:23:56]

lgtm

[Florian Schneider, 2016-07-14 17:48:54]

Description was changed from

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
==========

to

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
==========

[Florian Schneider, 2016-07-14 17:48:55]

Committed patchset #4 (id:60001) manually as
4a5f651c4b2202013ab7c3db887fd95e2597e173 (presubmit successful).

[Florian Schneider, 2016-07-15 01:50:38]

fschneider@google.com changed reviewers:
+ rmacnak@google.com

[Florian Schneider, 2016-07-15 01:50:38]

Ptal. Fixed debug assertion about slow-path exit label and duplicate safe
points.

[rmacnak, 2016-07-15 02:01:03]

lgtm

[Florian Schneider, 2016-07-15 16:49:35]

Description was changed from

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
==========

to

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
==========

[Florian Schneider, 2016-07-15 17:07:45]

Description was changed from

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
==========

to

==========
VM: Array bounds checks that don't deoptimize for precompiled code.

1. Make CheckArrayBoundInstr also check the index for smi. This allows easy
replacement
of the deoptimizing checks with the slow-path checks in the precompiler.

2. Add GenericCheckBoundInstr which has a slow-path attached for
handling check failures.

BUG=
R=rmacnak@google.com, vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4a5f651c4b2202013ab7c3db887fd95e2597e173
Committed:
https://github.com/dart-lang/sdk/commit/d3810213b0b185fc2fb9a6239f1f67fbb72e63b0
==========

[Florian Schneider, 2016-07-15 17:07:47]

Committed patchset #6 (id:100001) manually as
d3810213b0b185fc2fb9a6239f1f67fbb72e63b0 (presubmit successful).